feat(git): support custom commit flags for app-run commits by 0xnim · Pull Request #977 · pingdotgg/t3code

0xnim · 2026-03-12T15:07:13Z

Related to #274.

What Changed

Added support for passing extra git commit flags
Added a Settings field for app run git commit flags, so users can configure flags like --no-gpg-sign

Why

T3 Code runs git commit non-interactively. On a machine with global commit.gpgsign=true, commits can fail because GPG prompts for a pass on /dev/tty, which does not exist in this case.

This PR does NOT add interactive GPG/password support. Instead its a small workaround fix, users can configure extra commit flags for app run commits, which makes setups like --no-gpg-sign possible without changing their global git config

UI Changes

Adds a new Settings field under Git for extra git commit flags

Before	After

Checklist

This PR is small and focused
I explained what changed and why
I included before/after screenshots for any UI changes
I included a video for animation/interaction changes

Note

Add user-configurable extra git commit flags to app-run commits

Adds a gitCommitFlags setting (max 4096 chars) to appSettings.ts and exposes a UI input in the settings route with warnings for non-flag tokens.
Introduces tokenizeCommitFlags in GitManager.ts to parse raw flag strings into CLI tokens, filtering out any tokens that don't start with a dash.
Threads the sanitized flags from GitActionsControl → runStackedAction mutation → GitManager.runCommitStep → GitCore.commit → git commit invocation.
Risk: user-supplied flags are passed directly to git commit; only dash-prefixed tokens are filtered, but malformed flag values (e.g. --flag=value) are not further validated.

^{Macroscope summarized 9cc1019.}

coderabbitai · 2026-03-12T15:07:38Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7313ad83-deaa-466a-826b-c77d6253c219

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

You can disable the changed files summary in the walkthrough.

Disable the reviews.changed_files_summary setting to disable the changed files summary in the walkthrough.

0xnim · 2026-03-12T16:50:45Z

The worker errors seem to be pre existing

juliusmarminge · 2026-03-12T18:36:24Z

The worker errors seem to be pre existing

it's flaky right now but it keeps failing on this branch...

also can you resolve conflicts pls. i am unable to push since you PRd from main:

0xnim · 2026-03-12T20:36:56Z

Apologies, I never realized that was the reason you don't pr from main. I'll do it now.

0xnim · 2026-03-17T14:35:45Z

this is ready to go

- Move extra commit args after message flags to avoid swallowing `-m` - Drop non-flag tokens when tokenizing user-supplied commit flags - Add tests and clarify the settings helper text

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Shows a yellow warning when non-flag tokens are entered (tokens not starting with a dash), matching the server-side sanitization behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Show a clear message about using = syntax instead of quotes, before falling through to the non-flag token check. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Update tokenizer to handle --flag="value with spaces" and --flag='value with spaces' syntax. Update client-side validation to match. Remove "not supported yet" disclaimer from UI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Keep the text generation and git commit flag controls compact - Remove the extra git commit flag help text - Simplify the reset button conditional formatting

juliusmarminge · 2026-03-20T01:53:06Z

@macroscope-app review this

github-actions bot added the vouch:unvouched PR author is not yet trusted in the VOUCHED list. label Mar 12, 2026

juliusmarminge approved these changes Mar 12, 2026

View reviewed changes

juliusmarminge added the accepted feature request accepted label Mar 12, 2026

github-actions bot added size:M 30-99 changed lines (additions + deletions). size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Mar 12, 2026

0xnim marked this pull request as draft March 13, 2026 16:16

0xnim force-pushed the main branch from b0b03ae to 61a2654 Compare March 13, 2026 16:20

github-actions bot added size:M 30-99 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Mar 13, 2026

feat(git): support custom commit flags for app-run commits

5a57ada

0xnim force-pushed the main branch from 61a2654 to 5a57ada Compare March 13, 2026 16:21

0xnim marked this pull request as ready for review March 13, 2026 16:38

0xnim added 3 commits March 13, 2026 15:08

Merge branch 'main' into main

d2c6248

Merge branch 'main' into main

22cf222

Merge branch 'main' into main

c3af56e

Harden git commit extra flags

77a6449

- Move extra commit args after message flags to avoid swallowing `-m` - Drop non-flag tokens when tokenizing user-supplied commit flags - Add tests and clarify the settings helper text

github-actions bot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Mar 19, 2026

juliusmarminge and others added 6 commits March 19, 2026 12:07

Merge branch 'main' into main

97ab0fb

fmt

ee12fb6

defaults

5a07724

fix: merge duplicate Git settings sections into one

c7c060f

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: remove duplicate useAppSettings import and call

e106c1b

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: flatten text generation model input to match commit flags style

5016e59

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

juliusmarminge and others added 5 commits March 19, 2026 12:36

fix: hide git restore defaults button when already at defaults

5fc46ce

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat: add client-side validation for git commit flags input

bc62ef2

Shows a yellow warning when non-flag tokens are entered (tokens not starting with a dash), matching the server-side sanitization behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: detect quoted arguments in commit flags validation

a65db9a

Show a clear message about using = syntax instead of quotes, before falling through to the non-flag token check. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat: support quoted arguments in git commit flags

cb39166

Update tokenizer to handle --flag="value with spaces" and --flag='value with spaces' syntax. Update client-side validation to match. Remove "not supported yet" disclaimer from UI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Tighten settings layout for git options

b570ff5

- Keep the text generation and git commit flag controls compact - Remove the extra git commit flag help text - Simplify the reset button conditional formatting

0xnim added 2 commits March 20, 2026 10:04

Merge branch 'main' into main

a15b3b0

Merge branch 'main' into main

9cc1019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(git): support custom commit flags for app-run commits#977

feat(git): support custom commit flags for app-run commits#977
0xnim wants to merge 18 commits intopingdotgg:mainfrom
0xnim:main

0xnim commented Mar 12, 2026 •

edited by macroscopeapp bot

Loading

Uh oh!

coderabbitai bot commented Mar 12, 2026 •

edited

Loading

Review skipped

Uh oh!

0xnim commented Mar 12, 2026

Uh oh!

juliusmarminge commented Mar 12, 2026 •

edited

Loading

Uh oh!

0xnim commented Mar 12, 2026

Uh oh!

0xnim commented Mar 17, 2026

Uh oh!

juliusmarminge commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

0xnim commented Mar 12, 2026 • edited by macroscopeapp bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Changed

Why

UI Changes

Checklist

Add user-configurable extra git commit flags to app-run commits

Uh oh!

coderabbitai bot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

0xnim commented Mar 12, 2026

Uh oh!

juliusmarminge commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xnim commented Mar 12, 2026

Uh oh!

0xnim commented Mar 17, 2026

Uh oh!

juliusmarminge commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

0xnim commented Mar 12, 2026 •

edited by macroscopeapp bot

Loading

coderabbitai bot commented Mar 12, 2026 •

edited

Loading

juliusmarminge commented Mar 12, 2026 •

edited

Loading